Skip to content

chore(runway): cherry-pick feat(card): cp-7.64.0 create card-kyc-notification deep link handler#25703

Merged
joaoloureirop merged 1 commit into
release/7.64.0from
runway-cherry-pick-7.64.0-1770290882
Feb 5, 2026
Merged

chore(runway): cherry-pick feat(card): cp-7.64.0 create card-kyc-notification deep link handler#25703
joaoloureirop merged 1 commit into
release/7.64.0from
runway-cherry-pick-7.64.0-1770290882

Conversation

@runway-github
Copy link
Copy Markdown
Contributor

@runway-github runway-github Bot commented Feb 5, 2026

Description

This PR implements a deeplink handler for Card KYC push notifications,
allowing users to be routed to the appropriate screen based on their KYC
verification status when tapping on a notification about their
verification result.

Motivation: When users complete their KYC verification process, they
receive push notifications about the result. Previously, there was no
handler to deep link users directly to the relevant screen based on
their verification status.

Solution:

  • Added a new card-kyc-notification deeplink action that checks the
    user's KYC verification state and navigates accordingly
  • Handles two scenarios:
  1. Onboarding flow (user has onboardingId): Routes to KYCFailed,
    Complete (→ PersonalDetails), or KYCPending
  2. Authenticated flow (user is already logged in): Routes to
    KYCFailed, Complete (→ CardHome via SpendingLimit), or CardHome
  • Updated the Complete screen to accept a nextDestination route
    param for proper navigation after KYC approval
  • Added logic to suppress the "keep going" modal when users are
    deeplinked directly to the Complete screen
  • Added logout method to CardSDK for proper session cleanup
  • Refactored useCardProviderAuthentication to get location from Redux
    selector instead of function parameters

Changelog

CHANGELOG entry: Added deeplink handler for Card KYC push notifications
to route users to appropriate screens based on verification status

Related issues

Fixes:

Manual testing steps

Feature: Card KYC Notification Deeplink Handler

  Scenario: User taps KYC approved notification during onboarding
    Given user is in the Card onboarding flow with a pending KYC verification
    And user has an onboardingId stored in Redux

    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is VERIFIED
    Then user is navigated to the Complete screen
    And tapping Continue navigates to PersonalDetails

  Scenario: User taps KYC approved notification when authenticated
    Given user is authenticated with the Card provider
    And user has completed KYC verification

    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is VERIFIED
    Then user is navigated to the Complete screen
    And tapping Continue navigates to SpendingLimit screen

  Scenario: User taps KYC rejected notification
    Given user has submitted KYC verification
    
    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is REJECTED
    Then user is navigated to the KYCFailed screen

  Scenario: User taps notification while KYC is still pending
    Given user has submitted KYC verification
    
    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is PENDING
    Then user is navigated to the KYCPending screen (onboarding) or CardHome (authenticated)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Adds a new deeplink entry point and changes navigation/auth state handling, which could misroute users or regress card onboarding/auth flows if state/params aren’t set as expected.

Overview
Adds a new card-kyc-notification universal link action that inspects Card feature flags plus the user’s onboarding/auth state, fetches KYC verification status (via CardSDK), and deep-navigates to the appropriate Card screen (e.g., KYC_FAILED, KYC_PENDING, or COMPLETE with a nextDestination param).

Refactors Card authentication to source location from Redux (selectUserCardLocation) rather than passing it through login/OTP APIs, and updates UI to persist location selection in state.

Improves session cleanup by introducing CardSDK.logout() (server logout + always-clear local token) and wiring logoutFromProvider() to call it while still clearing Redux state on failures; CardHome now shows a toast when an authentication error forces logout/redirect. Also tweaks onboarding navigation (skip “keep going” modal when deeplinked to COMPLETE), adjusts close-button behavior to reset to Card Home, and updates related copy/SSN helper text and tests.

Written by Cursor Bugbot for commit d043390. This will update automatically on new commits. Configure here.


Co-authored-by: Alejandro Machado alejandro@macha.do
Co-authored-by: Kevin Le Jeune kevin.le-jeune@consensys.net 826b8b5

…fication deep link handler (#25607)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR implements a deeplink handler for Card KYC push notifications,
allowing users to be routed to the appropriate screen based on their KYC
verification status when tapping on a notification about their
verification result.

**Motivation**: When users complete their KYC verification process, they
receive push notifications about the result. Previously, there was no
handler to deep link users directly to the relevant screen based on
their verification status.

**Solution**: 
- Added a new `card-kyc-notification` deeplink action that checks the
user's KYC verification state and navigates accordingly
- Handles two scenarios:
1. **Onboarding flow** (user has onboardingId): Routes to KYCFailed,
Complete (→ PersonalDetails), or KYCPending
2. **Authenticated flow** (user is already logged in): Routes to
KYCFailed, Complete (→ CardHome via SpendingLimit), or CardHome
- Updated the `Complete` screen to accept a `nextDestination` route
param for proper navigation after KYC approval
- Added logic to suppress the "keep going" modal when users are
deeplinked directly to the Complete screen
- Added `logout` method to CardSDK for proper session cleanup
- Refactored `useCardProviderAuthentication` to get location from Redux
selector instead of function parameters

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added deeplink handler for Card KYC push notifications
to route users to appropriate screens based on verification status

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: Card KYC Notification Deeplink Handler

  Scenario: User taps KYC approved notification during onboarding
    Given user is in the Card onboarding flow with a pending KYC verification
    And user has an onboardingId stored in Redux

    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is VERIFIED
    Then user is navigated to the Complete screen
    And tapping Continue navigates to PersonalDetails

  Scenario: User taps KYC approved notification when authenticated
    Given user is authenticated with the Card provider
    And user has completed KYC verification

    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is VERIFIED
    Then user is navigated to the Complete screen
    And tapping Continue navigates to SpendingLimit screen

  Scenario: User taps KYC rejected notification
    Given user has submitted KYC verification
    
    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is REJECTED
    Then user is navigated to the KYCFailed screen

  Scenario: User taps notification while KYC is still pending
    Given user has submitted KYC verification
    
    When user taps on a push notification with the card-kyc-notification deeplink
    And the KYC status is PENDING
    Then user is navigated to the KYCPending screen (onboarding) or CardHome (authenticated)
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Adds new deeplink-driven navigation paths and changes how card
auth/logout manage tokens and location, which can affect user routing
and session handling. Risk is mitigated by extensive new/updated tests
but touches core Card flows and deep link handling.
> 
> **Overview**
> Adds a new `card-kyc-notification` deeplink action and handler that
routes users to the appropriate Card screen based on KYC verification
state, accounting for onboarding vs already-authenticated sessions and
ensuring the correct US/International location is used for provider API
calls.
> 
> Updates onboarding/navigation to support this deeplink flow by adding
a `nextDestination` param to the `Complete` screen, suppressing the
“keep going” modal when deeplinking directly to `Complete`, and
adjusting the onboarding header close behavior to reset navigation back
to `CardHome`.
> 
> Improves session cleanup by introducing `CardSDK.logout()` (server
logout + always-clear local token), showing a session-expired toast on
auth errors in `CardHome`, and refactoring card authentication to source
`location` from Redux (and persist it via selection) rather than passing
it through login/OTP call parameters; copy updates add clearer phone/SSN
guidance and fix onboarding button text.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d31a4e4. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Alejandro Machado <alejandro@macha.do>
Co-authored-by: Kevin Le Jeune <kevin.le-jeune@consensys.net>
@runway-github runway-github Bot requested review from a team as code owners February 5, 2026 11:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Feb 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.64.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 5, 2026

@joaoloureirop joaoloureirop enabled auto-merge (squash) February 5, 2026 12:12
@joaoloureirop joaoloureirop merged commit 05850d9 into release/7.64.0 Feb 5, 2026
96 of 97 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.64.0-1770290882 branch February 5, 2026 12:19
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Feb 6, 2026
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.64.0 on PR, as PR was cherry-picked in branch 7.64.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-XL team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants